[PATCH] D74122: [CallSiteInfo] Use the isCandidateForCallSiteEntry() when update the cs info

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1445
+      // Update the call site info.
+      if (MI.isCandidateForCallSiteEntry())
+        MF->moveCallSiteInfo(&MI, &*MIB);
----------------
djtodoro wrote:
> chill wrote:
> > Likewise, isn't this redundant, given we have `TPsoft`/`tTPsoft`, both of which have `isCall = 1`?
> I think it is not, since we do not consider all posible calls as ‘call site entry candidates’. The call site info is used for debug entry values feature only (for now).
Hmm...but if these are the only instructions we handle here, we can avoid these checks actually... And it is safe, since we have the assertions within ‘*callSiteInfo’ ensuring we call it only in the case of call site entry candidates.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74122/new/

https://reviews.llvm.org/D74122