[PATCH] D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added.

[Eric Schweitz via Phabricator via llvm-commits]

schweitz marked 3 inline comments as done.
schweitz added inline comments.


================
Comment at: flang/documentation/BijectiveInternalNameUniquing.md:34
+```
+    submodule (mod:s1mod) s2mod
+      ...
----------------
tskeith wrote:
> Submodules of an ancestor module have to have distinct names, so you don't need to include `s1mod` in the unique name for `s2mod` (though it doesn't hurt). So the unique name for `smod2` could be just `_QMmodSs2mod`.
True. It seemed the more cautious approach to include more information about the symbol origin.


================
Comment at: flang/documentation/BijectiveInternalNameUniquing.md:49
+
+   * A common block name will be prefixed with `B`
+
----------------
tskeith wrote:
> What about the blank common block? Is its name just `_QB`?
Yes.


================
Comment at: flang/documentation/BijectiveInternalNameUniquing.md:58
+
+   * A procedure/subprogram is prefixed with `P`
+
----------------
tskeith wrote:
> On line 30 it says `F` is the prefix. `P` makes more sense to me.
One (F) signifies scope and the other (P) identity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79089/new/

https://reviews.llvm.org/D79089