[PATCH] D76518: [ARM] CMSE code generation

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 02:02:36 PDT 2020


chill marked 2 inline comments as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1965
+        NewCall->addOperand(MI.getOperand(I));
+      MI.getMF()->moveCallSiteInfo(&MI, NewCall.getInstr());
+
----------------
dmgreen wrote:
> chill wrote:
> > This added line is the last change.
> Do we need to call if (MI.isCandidateForCallSiteEntry())?
I don't think so, we know exactly that we're replacing a `tBXNS_CALL`, for which `isCandidateForCallSiteEntry` ought to return true.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76518/new/

https://reviews.llvm.org/D76518





More information about the llvm-commits mailing list