[PATCH] D79146: [MLIR][docs] Update tutorial language around Op and Operation* and 'opaque'

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 16:39:55 PDT 2020


rriddle accepted this revision.
rriddle marked an inline comment as done.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/docs/OpDefinitions.md:352
+[Operation interfaces](Interfaces.md#operation-interfaces) are a
+mechanism allowing operations to expose method calls, without the
+caller needing to know the exact operation type. Operation interfaces
----------------
stephenneuendorffer wrote:
> rriddle wrote:
> > nit: allowing -> by which operations can expose?
> I think it reads better with the simpler construction.  Maybe even "operation interfaces allow operations to expose..."
SGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79146/new/

https://reviews.llvm.org/D79146





More information about the llvm-commits mailing list