[PATCH] D79206: [mlir][OpBuilder] Remove the vtable from OpBuilder in favor of using the listener pattern

Thu Apr 30 15:38:59 PDT 2020

ftynse accepted this revision.
ftynse added a comment.

Thanks, River!

I am not sure I completely understand the relation of this with EDSC/ScopedContext (I expect it to be just transparent), but we intend to clean the ScopedContext soon anyway.

================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:389
+    // FIXME: This should keep the same listener.
+    b.setListener(nullptr);
+
----------------
Could you please elaborate why this is necessary? There are other uses of GenericLoopNestRangeBuilder in LinalgToLoops that are not modified...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79206/new/

https://reviews.llvm.org/D79206