[PATCH] D78186: [flang] Don't check __cplusplus value with MSVC.

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 15:06:37 PDT 2020


aaron.ballman added a comment.

In D78186#1992835 <https://reviews.llvm.org/D78186#1992835>, @ChinouneMehdi wrote:

> In D78186#1992728 <https://reviews.llvm.org/D78186#1992728>, @sscalpone wrote:
>
> > > Do you mean whole Flang or this particular case?
> >
> > Just this case.  I mean, preserve the original code in this change for non-windows systems.
>
>
> We can add a compilation flag `/Zc:__cplusplus` to make MSVC correctly report __cplusplus .


This seems like the correct way to solve this bug, to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78186/new/

https://reviews.llvm.org/D78186





More information about the llvm-commits mailing list