[PATCH] D78035: [PoC][RISCV] enable LTO/ThinLTO on RISCV

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/test/LTO/RISCV/mabi-invalid.ll:10
+; RUN: opt -module-summary -o %t2.summary %S/Inputs/foo_ilp32.ll
+; RUN: llvm-lto2 run -r %t2.summary,foo,plx -r %t1.summary,main,plx -r %t1.summary,foo, -o %t3 %t1.summary %t2.summary 2>&1 | FileCheck %s
+
----------------
Here's another case where the regular LTO testing is using the old LTO API (via llvm-lto) and ThinLTO is using the new LTO API (via llvm-lto2). As noted earlier, all 4 combinations should be tested.


================
Comment at: llvm/test/tools/gold/RISCV/mixed_lto.ll:19
+; RUN: opt %s -module-hash -module-summary -o %thin0.o
+; RUN: opt %p/miaxed_lto.ll  -module-hash -module-summary -o %thin1.o
+; RUN: %gold -m elf32lriscv -plugin %llvmshlibdir/LLVMgold%shlibext \
----------------
There's a typo in the input name "miaxed_lto.ll". If the test worked despite that then it probably needs some improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78035/new/

https://reviews.llvm.org/D78035