[PATCH] D79002: [NFC][CostModel] Add TargetCostKind to relevant APIs

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 12:21:16 PDT 2020


mtrofin added a comment.

In D79002#2007888 <https://reviews.llvm.org/D79002#2007888>, @samparker wrote:

> Good idea, done.


(Nit) Could you link the RFC in the message?



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:926
                       unsigned AddressSpace,
+                      TTI::TargetCostKind CostKind,
                       const Instruction *I = nullptr) const;
----------------
Why not also default value CostKind here, too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79002/new/

https://reviews.llvm.org/D79002





More information about the llvm-commits mailing list