[PATCH] D79092: [Flang][Driver]Add new flang driver main() entrypoint

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 12:53:51 PDT 2020


awarzynski added a comment.

> What's the level-of-effort required to extract the shared functionality into llvm/lib/Frontend?

@sscalpone , let me chime in. This patch only really requires `clang::DiagnosticsEngine` (from `clangBasic`) and `clang::driver` (from `clangDriver`), so not that much. Extracting thess into a separate library shouldn't be too difficult on it's own. However, it would mean redefining the libraries in clang.

- This is likely to have a huge impact on a lot of mature upstream and downstream LLVM projects (these projects would have to re-define their dependencies)
- In my opinion this should be discussed with the community first (i.e. via llvm-dev, cfe-dev and flang-dev)
- It could have bigger impact on LLVM/clang that I don't see right now.

Also, as we make progress we are likely to discover that we need to repeat this exercise a few more times (i.e. refactor more clang components).

We wanted to take an alternative approach -  develop a clang-based replacement for `flang` (the bash wrapper) and only then refactor the common bits into a dedicated library. I think that at that point we will be better informed as what exactly is required and truly _common_.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79092/new/

https://reviews.llvm.org/D79092





More information about the llvm-commits mailing list