[PATCH] D78615: [ValueTracking] Let propagatesPoison support binops/unaryops/cast/etc.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 10:41:08 PDT 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

Thanks for running the alive experiment. The results look pretty compelling and are in line with what I'd expect. Giving one instruction special poison semantics has a snowball effect that will quickly lead us to undef-like reasoning.

This LG to me, but please wait for a second opinion.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4852
+  case Instruction::Select:
+  case Instruction::PHI:
+    return false;
----------------
Maybe list call/invoke explicitly here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78615/new/

https://reviews.llvm.org/D78615





More information about the llvm-commits mailing list