[PATCH] D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added.

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 09:02:49 PDT 2020


kiranchandramohan added a comment.

Thanks @schweitz for the detailed reply.

I have a couple more questions.
-> Isn't this necessary for the Block construct?
-> Will uniquing all names lead to lower readability of the IR? (Assuming that is what being proposed here) 
-> Yeah, renaming local variables back to original names (during lowering to LLVM IR) when there is no clash seems better for readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79089/new/

https://reviews.llvm.org/D79089





More information about the llvm-commits mailing list