[PATCH] D79175: [ARM][MVE] Support intrinsic @llvm.set.loop.elements in the tail-predication pass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

In D79175#2012797 <https://reviews.llvm.org/D79175#2012797>, @samparker wrote:

> I was really hoping to see a lot of stuff being deleted from this pass, not added... isn't half of the original code now redundant?


Copied from the description of this change:

> Now we pick up this intrinsic the number of elements, which simplifies the pattern matching we were doing to find this value. I have not yet removed the pattern matching because that would require changing of a lot of tests. Thus, for now, the intrinsic and pattern matching coexist together, but as a follow up we probably want to remove this.

I propose we focus on handling first this new intrinsic. At this moment the original code is still used, because it will be triggered by all existing tests which need updating.
Handling intrinsics, removing half the code, and updating all tests is a massive change that doesn't make reviewing it easier, so thought that this is best done in steps, and this is the first one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79175/new/

https://reviews.llvm.org/D79175