[PATCH] D79152: [NFC] Rename *ByValOrInalloca* to *PassPointeeByValue*

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 07:21:24 PDT 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Naming looks good, please commit after updating the two doc comments.



================
Comment at: llvm/include/llvm/IR/Argument.h:74-75
 
   /// Return true if this argument has the byval attribute or inalloca
   /// attribute. These attributes represent arguments being passed by value.
+  bool hasPassPointeeByValueAttr() const;
----------------
Since the preallocated attribute exists now, please update this to include it.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1544
 
   /// Determine whether this argument is passed by value or in an alloca.
+  bool isPassPointeeByValueArgument(unsigned ArgNo) const {
----------------
Also needs a tweak


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79152/new/

https://reviews.llvm.org/D79152





More information about the llvm-commits mailing list