[PATCH] D78431: [ELF][PPC64] Suppress toc-indirect to toc-relative relaxation if R_PPC64_TOC16_LO is seen

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 06:46:42 PDT 2020


sfertile accepted this revision.
sfertile added a comment.

One minor comment but otherwise LGTM. Thanks for fixing this.



================
Comment at: lld/ELF/Relocations.cpp:1325
+    if (type == R_PPC64_TOC16_LO)
+      ppc64noTocRelax.insert({&sym, addend});
+  }
----------------
We should check that the symbol is a section, and that the sections name is ".toc" before adding it to the map as well.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78431/new/

https://reviews.llvm.org/D78431





More information about the llvm-commits mailing list