[PATCH] D78907: [RISCV] Add tests for checking isnan patterns

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 03:37:15 PDT 2020


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM. Minor nit: using %0 and %2 as the only two named values seems odd though? Most other tests in test/CodeGen/RISCV use a/b/... for arguments and %0/%1/%2/... in the body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78907/new/

https://reviews.llvm.org/D78907





More information about the llvm-commits mailing list