[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1134
                                    AArch64::ArchKind::INVALID, "sve2"));
+  EXPECT_TRUE(
+      testAArch64Extension("carmel", AArch64::ArchKind::INVALID, "fp16"));
----------------
tambre wrote:
> sdesmalen wrote:
> > nit: It seems a bit arbitrary to only check for fp16 here?
> I based this off mostly of what was already here. I think most extensions are covered by architecture extension tests. I've added crypto here though.
Cheers, that's should indeed be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77940/new/

https://reviews.llvm.org/D77940