[PATCH] D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 01:12:44 PDT 2020


lenary updated this revision to Diff 261139.
lenary added a comment.

Update after shiva0217's review:

- Update test to correctly show splitting on RV32*C
- Use early return if `CSI.size() == 0`
- Update comments to count bits correctly.

I decided against a `getOffsetAddressableLimit` function, as the logic in
`getFirstSPAdjustAmount` isn't just about addressable offsets, it's also about
what we can adjust in a single (compressed if possible) instruction, so I
thought that adding that function would make the logic harder to understand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79141/new/

https://reviews.llvm.org/D79141

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
  llvm/test/CodeGen/RISCV/split-sp-adjust.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79141.261139.patch
Type: text/x-patch
Size: 15665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/7ffdd17c/attachment.bin>


More information about the llvm-commits mailing list