[PATCH] D78988: [LTO] Suppress emission of the empty object file

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/linker-script-symbols-assign.ll:7
 ; RUN: ld.lld %t.o -o %t2 --script %t.script -save-temps
+; Combined module is not empty, but it will be empty after optimization.
+; Ensure ld still emits empty combined obj in this case.
----------------
Use `;; ` for comments. For newer tests we are enforcing this rule.


================
Comment at: lld/test/ELF/lto/thinlto-obj-path.ll:18
+; Ensure ld emits empty combined module if specific obj-path.
+; RUN: rm -fr %T/objpath
+; RUN: mkdir %T/objpath
----------------
`%T` is currently deprecated. You can use `rm -fr %t.dir && mkdir %t.dir/objpath`


================
Comment at: lld/test/ELF/lto/thinlto-obj-path.ll:20
+; RUN: mkdir %T/objpath
+; RUN: ld.lld --plugin-opt=obj-path=%t4.o -shared %t1.o %t2.o -o %T/objpath/a.out -save-temps
+; RUN: ls %T/objpath/a.out*.lto.* | count 3
----------------
`--save-temps`

Unless the single dash option is prevailing (-pie -shared etc), we prefer double-dash long options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78988/new/

https://reviews.llvm.org/D78988