[PATCH] D79131: [IRBuilder] Don't crash when creating alloca/load/store in unparented block.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 16:12:54 PDT 2020


efriedma added a comment.

The direction we're moving is that load/store instructions will store an "Align", not a "MaybeAlign". So it will be impossible to leave the alignment unspecified.

It would be possible to store the DataLayout as a member of the IRBuilder, so it's possible to query the datalayout even if the basic block doesn't have a parent, I guess.  Not sure what the use-case would be, though; I can't imagine creating a basic block without knowing what function it will be attached to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79131/new/

https://reviews.llvm.org/D79131





More information about the llvm-commits mailing list