[PATCH] D79107: Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Note, your original commit 66947d05fd193bb8948943a62455d617974f2012 <https://reviews.llvm.org/rG66947d05fd193bb8948943a62455d617974f2012> and several recent commits don't correctly have `Differential Revision: https://reviews.llvm.org/Dxxxxx`

So the differential revision was not closed automatically when you pushed the commit to origin/master.

I usually do this when committing: `arcfilter; git pull --rebase origin master; last-minute-testing && git push origin HEAD:master` where `arcfilter` is a shell function which drops unneeded Phabricator tags

  arcfilter () {
    arc amend
    git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F -
  }


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79107/new/

https://reviews.llvm.org/D79107