[PATCH] D79053: [SVE] Fix invalid use of VectorType::getNumElements() in Value Tracking

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 12:55:09 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1946
+  if (isa<ConstantVector>(V) && !EC->Scalable) {
+    const auto *CV = cast<ConstantVector>(V);
+    assert((CV->getNumOperands() == EC->Min) &&
----------------
ctetreau wrote:
> efriedma wrote:
> > No reason to check Scalable; a ConstantVector is never scalable anyway.
> ConstantVector::getSplat() can return a scalable ConstantVector
I guess it actually returns a ConstantExpr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79053/new/

https://reviews.llvm.org/D79053





More information about the llvm-commits mailing list