[PATCH] D79017: [mlir][llvm] Fix llvmBuilder for llvm.alloca so it could emit to non-zero addrspace.

Wen-Heng (Jack) Chung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 12:22:29 PDT 2020


whchung added a comment.

@ftynse I reclaimed the patch. But I'm not sure how to add an extra test specifically for this patch without `mlir-translate` changes introduced in D79019 <https://reviews.llvm.org/D79019>.

In `mlir/test/Target/llvmir.mlir` there are tests which checks this particular function how `llvm.alloca` gets translated to llvm `alloca` instruction. They are working fine.

And without D79019 <https://reviews.llvm.org/D79019>, there is really no way for `mlir-translate` to emit `alloca` on a different addrspace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79017/new/

https://reviews.llvm.org/D79017





More information about the llvm-commits mailing list