[PATCH] D79110: Turning on Heat Colors for CFG by default

[Kirill Naumov via Phabricator via llvm-commits]

knaumov created this revision.
knaumov added reviewers: apilipenko, davidxl, rcorcs, sfertile, fedor.sergeev.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

This option seems to be very useful, so let's turn it on by default.
Concerning the test, it was not constructed to do the tests locally, so I have rewritten it a bit without changing its essence.


https://reviews.llvm.org/D79110

Files:
  llvm/lib/Analysis/CFGPrinter.cpp
  llvm/test/Other/cfg_deopt_unreach.ll


Index: llvm/test/Other/cfg_deopt_unreach.ll
===================================================================
--- llvm/test/Other/cfg_deopt_unreach.ll
+++ llvm/test/Other/cfg_deopt_unreach.ll
@@ -12,24 +12,20 @@
 declare i8 @llvm.experimental.deoptimize.i8(...)
 
 define i8 @callee(i1* %c) alwaysinline {
-; NO-FLAGS: [shape=record,label="{%0:\l  %c0 = load volatile i1, i1* %c\l  br i1 %c0, label %lleft, label %lright\l|{<s0>T|<s1>F}}"];
-; DEOPT: [shape=record,label="{%0:\l  %c0 = load volatile i1, i1* %c\l  br i1 %c0, label %lleft, label %lright\l|{<s0>T|<s1>F}}"];
-; UNREACH: [shape=record,label="{%0:\l  %c0 = load volatile i1, i1* %c\l  br i1 %c0, label %lleft, label %lright\l|{<s0>T|<s1>F}}"];
-; BOTH-FLAGS-NOT: [shape=record,label="{%0:\l  %c0 = load volatile i1, i1* %c\l  br i1 %c0, label %lleft, label %lright\l|{<s0>T|<s1>F}}"];
   %c0 = load volatile i1, i1* %c
   br i1 %c0, label %lleft, label %lright
-; NO-FLAGS: [shape=record,label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"];
-; DEOPT-NOT: [shape=record,label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"];
-; UNREACH: [shape=record,label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"];
-; BOTH-FLAGS-NOT: [shape=record,label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"];
+; NO-FLAGS: label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"
+; DEOPT-NOT: label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"
+; UNREACH: label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"
+; BOTH-FLAGS-NOT: label="{lleft:                                            \l  %v0 = call i8 (...) @llvm.experimental.deoptimize.i8(i32 1) [ \"deopt\"(i32 1)\l... ]\l  ret i8 %v0\l}"
 lleft:
   %v0 = call i8(...) @llvm.experimental.deoptimize.i8(i32 1) [ "deopt"(i32 1) ]
   ret i8 %v0
 
-; NO-FLAGS: [shape=record,label="{lright:                                           \l  unreachable\l}"];
-; DEOPT: [shape=record,label="{lright:                                           \l  unreachable\l}"];
-; UNREACH-NOT: [shape=record,label="{lright:                                           \l  unreachable\l}"];
-; BOTH-FLAGS-NOT: [shape=record,label="{lright:                                           \l  unreachable\l}"];
+; NO-FLAGS: label="{lright:                                           \l  unreachable\l}"
+; DEOPT: label="{lright:                                           \l  unreachable\l}"
+; UNREACH-NOT: label="{lright:                                           \l  unreachable\l}"
+; BOTH-FLAGS-NOT: label="{lright:                                           \l  unreachable\l}"
 lright:
   unreachable
 }
Index: llvm/lib/Analysis/CFGPrinter.cpp
===================================================================
--- llvm/lib/Analysis/CFGPrinter.cpp
+++ llvm/lib/Analysis/CFGPrinter.cpp
@@ -42,7 +42,7 @@
 static cl::opt<bool> HideDeoptimizePaths("cfg-hide-deoptimize-paths",
                                          cl::init(false));
 
-static cl::opt<bool> ShowHeatColors("cfg-heat-colors", cl::init(false),
+static cl::opt<bool> ShowHeatColors("cfg-heat-colors", cl::init(true),
                                     cl::Hidden,
                                     cl::desc("Show heat colors in CFG"));
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79110.260975.patch
Type: text/x-patch
Size: 3974 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/639e7842/attachment.bin>