[PATCH] D76705: [SystemZ] Improve foldMemoryOperandImpl: vec->FP conversions

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 260925.
jonpa added a comment.

> Does this make sense?

I tried this... One drawback is that the flags of the memfold pseudo must now be carefully transferred from the target memory instruction. I found that only ADB and SDB sets CC, while MDB and DDB do not - it was nice before in a way to have all of that defined in only one place. So I had to use one more class that defines a pseudo that sets CC... I also had to cancel out the isCommutableFlag on the memfold-pseudo.

I am not sure exactly which way is the cleanest - what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76705/new/

https://reviews.llvm.org/D76705

Files:
  llvm/lib/Target/SystemZ/SystemZInstrFormats.td
  llvm/lib/Target/SystemZ/SystemZInstrInfo.cpp
  llvm/lib/Target/SystemZ/SystemZInstrVector.td
  llvm/test/CodeGen/SystemZ/foldmemop-vec-binops.mir
  llvm/test/CodeGen/SystemZ/foldmemop-vec-cc.mir
  llvm/test/CodeGen/SystemZ/foldmemop-vec-cmp.mir
  llvm/test/CodeGen/SystemZ/foldmemop-vec-fusedfp.mir
  llvm/test/CodeGen/SystemZ/foldmemop-vec-unary.mir
  llvm/test/CodeGen/SystemZ/int-cmp-56.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76705.260925.patch
Type: text/x-patch
Size: 162295 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/67dbc801/attachment.bin>