[PATCH] D79060: [MLIR] Introduce op trait PolyhedralScope (revised)

Wed Apr 29 01:34:31 PDT 2020

bondhugula added a comment.

In D79060#2009621 <https://reviews.llvm.org/D79060#2009621>, @ftynse wrote:

> In D79060#2009214 <https://reviews.llvm.org/D79060#2009214>, @bondhugula wrote:
>
> > ModuleOp is now marked with this trait as well. The trait lives in IR - as discussed here (https://reviews.llvm.org/D78863?id=260322#inline-722790), the trait makes sense even for those that don't depend on the affine dialect, and it's clean/logical to mark FuncOp/ModuleOp with this trait. The cyclic dependence b/w Affine and IR/ is now eliminated.
>
>
> I don't think we reached final consensus on this point, but I vote for landing this regardless of the current implementation and discussing the layering separately on discourse.  (If @rriddle is about to split OpTraits into several parts, all traits will then move in a consistent way).
>
> Please wait for @rriddle to approve.

I agree that there may be a better place for this trait to reside. But since a split may be in the works for other traits as well, we can have that happen separately first.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79060/new/

https://reviews.llvm.org/D79060