[PATCH] D76977: [lld-macho] Implement basic export trie

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 22:39:51 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/MachO/ExportTrie.cpp:138
+TrieNode *TrieBuilder::makeNode() {
+  auto node = make<TrieNode>();
+  nodes.emplace_back(node);
----------------
Nit: `auto *`


================
Comment at: lld/test/MachO/symtab.s:6
 
 # CHECK:      Symbols [
 # CHECK-NEXT:   Symbol {
----------------
I wish we can have a conciser `llvm-readobj` output... Due to llvm-readobj's verbosity, I prefer `llvm-readelf` for ELF objects...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76977/new/

https://reviews.llvm.org/D76977





More information about the llvm-commits mailing list