[PATCH] D79061: [ELF] --gdb-index: support .debug_loclists

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 21:35:07 PDT 2020


MaskRay added a comment.

In D79061#2009323 <https://reviews.llvm.org/D79061#2009323>, @dblaikie wrote:

> I'm surprised that generating gdb-index requires reading any debug locations - is there any chance of refactoring the APIs to make this not needed at all? (I mean, the bug fix is probably still a good thing - but maybe if the libDebugInfoDWARF APIs were changed the StringSwitch could be selective rather than exhaustive, just about the sections needed for gdb-index)


An alternative fix is to change https://github.com/llvm/llvm-project/blob/master/llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp#L543 (`DWARFUnit::tryExtractDIEsIfNeeded`) to optionally decode .debug_loclists, and let --gdb-index not decode .debug_loclists, but I think the complexity may be larger...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79061/new/

https://reviews.llvm.org/D79061





More information about the llvm-commits mailing list