[PATCH] D78989: [NFC] [PowerPC] Narrow fast-math flags in tests

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 17:50:17 PDT 2020


steven.zhang added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/scalar-equal.ll:55
 entry:
-  %cmp = fcmp fast oeq double %a, %b
-  %cond = select fast i1 %cmp, double %c, double %d
+  %cmp = fcmp oeq double %a, %b
+  %cond = select i1 %cmp, double %c, double %d
----------------
The change here is questionable. If we have the fast flag set, we shouldn't see the different instruction sequence w/o --enable-unsafe-fp-math. Please double confirm with compiler implementation to see what happens.


================
Comment at: llvm/test/CodeGen/PowerPC/scalar-min-max.ll:131
 entry:
-  %cmp = fcmp fast ogt float %a, %b
+  %cmp = fcmp ogt float %a, %b
   %cond = select i1 %cmp, float %a, float %b
----------------
The same as above comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78989/new/

https://reviews.llvm.org/D78989





More information about the llvm-commits mailing list