[PATCH] D76869: [Clang] Restore replace_path_prefix instead of startswith

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 16:13:16 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/test/Preprocessor/file_test_windows.c:12
+// CHECK: filename: "A:\\UNLIKELY_PATH\\empty\\file_test_windows.c"
+// CHECK: filename: "A:\\UNLIKELY_PATH\\empty{{/|\\\\}}Inputs/include-file-test/file_test.h"
+// CHECK: basefile: "A:\\UNLIKELY_PATH\\empty\\file_test_windows.c"
----------------
Can `{{/|\\\\}}` be simplified?


================
Comment at: clang/test/Preprocessor/file_test_windows.c:17
+// CHECK-EVIL: filename: "A:\\UNLIKELY_PATH=empty\\file_test_windows.c"
+// CHECK-EVIL: filename: "A:\\UNLIKELY_PATH=empty{{/|\\\\}}Inputs/include-file-test/file_test.h"
+// CHECK-EVIL: basefile: "A:\\UNLIKELY_PATH=empty\\file_test_windows.c"
----------------
ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76869/new/

https://reviews.llvm.org/D76869





More information about the llvm-commits mailing list