[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 11:17:24 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:735
       continue;
     // Ensure that we don't verify the same variables twice.
     const NamedTypeConstraint *variable = resolver.getVariable();
----------------
We will also need to add verification of the attribute here if the transformer is non-trivial.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78434/new/

https://reviews.llvm.org/D78434





More information about the llvm-commits mailing list