[PATCH] D79013: [llvm-readelf] - Do not crash when the PT_INTERP has a broken offset.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 11:17:16 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-phdrs.test:316
+
+## ERROR-INTERP1:      Type   Offset
+## ERROR-INTERP1-NEXT: INTERP 0xffffffff
----------------
Isn't the test covered by `ERROR-INTERP2`?


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4154
+
+      OS << "      [Requesting program interpreter: ";
+      OS << StringRef(Data, Len) << "]";
----------------
The two lines can be joined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79013/new/

https://reviews.llvm.org/D79013





More information about the llvm-commits mailing list