[PATCH] D77789: [llvm-dwarfdump][Stats] Clean up

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-dwarfdump.rst:169
+
+As mentioned above, :option:`--statistics` generates single-line JSON
+representing the Debug Info quality metrics.
----------------
The :option:`--statistics` option generates single-line JSON output
representing quality metrics of the processed debug info. These metrics are useful
to compare changes between two compilers, particularly for judging the effect
that a change to the compiler has on the debug info quality.

The output is formatted as key-value pairs. The first pair contains a version number.
The following naming scheme is used for the keys:

...


================
Comment at: llvm/docs/CommandGuide/llvm-dwarfdump.rst:175
+      - `variables` ==> all local variables and parameters
+      - `all local vars` ==> all local variables
+      - `all params` ==> all formal parameters
----------------
why `all` only in the second case?


================
Comment at: llvm/docs/CommandGuide/llvm-dwarfdump.rst:178
+
+For the cases we needed to do the math we use a syntax as so:
+
----------------
For aggregated values, the following keys are used: 


================
Comment at: llvm/docs/CommandGuide/llvm-dwarfdump.rst:182
+      - `#bytes` ==> the number of bytes
+      - `#variables \\ entry values ...` ==> the number of variables excluding
+        the entry values etc.
----------------
`-` instead of `\\`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77789/new/

https://reviews.llvm.org/D77789