[PATCH] D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types

Jean-Michel Gorius via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 08:34:12 PDT 2020

Previous message: [PATCH] D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types
Next message: [PATCH] D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Kayjukh added a comment.

nit: The commit message looks a little convoluted. Maybe you could simplify/structure it a little bit.
Otherwise, LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79004/new/

https://reviews.llvm.org/D79004

Previous message: [PATCH] D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types
Next message: [PATCH] D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list