[PATCH] D79001: [ARM][MVE] Tail-predication: support nested loops with dependent iterators.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 08:02:06 PDT 2020


SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:573
+  // will be safe because if these values don't match, we bail and don't peform
+  // tail-predication.
+  LLVM_DEBUG(dbgs() << "ARM TP: Matching scalar TC: "; TCP.NumElements->dump());
----------------
samparker wrote:
> I think it would be more informative to explain most of this using SCEV expression examples, I'm struggling to understand what's happening here.
yeah, good point, was just thinking the same, and thought this would be incomprehensible indeed without some SCEV examples.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79001/new/

https://reviews.llvm.org/D79001





More information about the llvm-commits mailing list