[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s:82
+       .section        .debug_line,"", at progbits
+       .section        .debug_info,"", at progbits
+.Lcu_begin1:
----------------
ikudrin wrote:
> The definitions for both CUs should lay under one `.section` directive. In that case, a reader can easily see that there are two CUs in the test. If there are several `.section` directives for one section, it makes reading the test more difficult.
> 
> The same for other sections.
Thanks for clearing this!, I will make sure to follow this practice in all test cases and revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736