[PATCH] D78954: [LLD][ELF] Add isDebug flag to SectionBase.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 05:19:38 PDT 2020


avl added a comment.

> I added a comment about this previously, I think it was not answered?
> https://reviews.llvm.org/D74169#inline-709439



> My assumption was that it is a premature unproved optimization (while you did not show the numbers, e.g. link time with/without it).
> (Honestly I would be surprised to see a speed-up after doing this. At least while you have cases with 889% link time, my feeling is that something else is slow, but not this).

you are right. It does not have noticeable effect. would close that review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78954/new/

https://reviews.llvm.org/D78954





More information about the llvm-commits mailing list