[PATCH] D78987: [BPI][NFC] Reuse post dominantor tree from analysis manager when available

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 04:15:38 PDT 2020


skatkov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1774
   BranchProbabilityInfo BPI;
-  BPI.calculate(F, LI);
+  BPI.calculate(F, LI, &TLI, nullptr);
   InductiveRangeCheckElimination IRCE(SE, &BPI, DT, LI);
----------------
why nullptr instead of request Pass manager for analysis if it is created anyway?


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:366
   BranchProbabilityInfo BPI;
-  BPI.calculate(*F, AR.LI);
+  BPI.calculate(*F, AR.LI, &AR.TLI, nullptr);
   LoopPredication LP(&AR.AA, &AR.DT, &AR.SE, &AR.LI, &BPI);
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78987/new/

https://reviews.llvm.org/D78987





More information about the llvm-commits mailing list