[PATCH] D78698: [VE] Implements minimum MC layer for VE

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

I guess this is ok from the technical side. However, as it is, this patch is quite large and fixes bugs in existing code and adds new functionality at the same time. How about we split this up into three patches:

1. Fixes for the instruction bit encoding.
2. The 'EM_VE' ELF changes
3. The VEAsmParser and tests.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:246
 }
+// AS assembly instrcution format:
+def VEMEMriAsmOperand : AsmOperandClass {
----------------
typo 


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:261
 def brtarget32 : Operand<OtherVT> {
-  let EncoderMethod = "getBranchTarget32OpValue";
 }
----------------
Is this a related change? (same in l265).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78698/new/

https://reviews.llvm.org/D78698