[PATCH] D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

What happens currently without this change? I'm guessing it tries to read something bad?

FWIW, ELF's yaml2obj now has the ability to add data blocks to an ELF, without generating a section header. See the "Fill" section type. Perhaps that's something that could be implemented in COFF's version at some point?

Aside from that, this all looks okay to me, but I'd like another opinion, as I'm not too familiar with COFF.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/debug-directory-unmapped.test:1
+# RUN: yaml2obj %s -o %t.exe
+
----------------
It might be worth a comment at the start of this test explaining what exactly is being tested, as it's not particularly obvious to me just looking at the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78920/new/

https://reviews.llvm.org/D78920