[PATCH] D78782: Add .debug_ranges support to the DWARF YAML.

Tue Apr 28 00:29:45 PDT 2020

jhenderson added a comment.

In D78782#2006883 <https://reviews.llvm.org/D78782#2006883>, @clayborg wrote:

> In D78782#2004682 <https://reviews.llvm.org/D78782#2004682>, @jhenderson wrote:
>
> > Does this patch add support in yaml2obj for debug_ranges (I get a bit lost as to what point this happens)? If it is newly supported, it should be tested in a yaml2obj test too.
>
>
> Already take care of with the test I added:
>
>   # RUN: yaml2obj %s | obj2yaml | FileCheck %s
>
>
> I was looking around to see how the existing DWARF yaml code was tested and didn't find any great examples that split things up this way.

That's not exactly testing what I'd expect. The obj2yaml output emits an Entries tag with a series of Offsets, but the input to yaml2obj in the test just uses raw content. I'd expect to see a yaml2obj input that consumes an Entries array, effectively showing that what obj2yaml emits can be consumed by yaml2obj.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78782/new/

https://reviews.llvm.org/D78782