[PATCH] D78796: [Support] Refactor LEB128 encoding into an input iterator

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 23:09:00 PDT 2020


dblaikie added a comment.

I'm not sure this is worth a full iterator abstraction - would the uses be that much the worse for it if they had a non-iterator type they had to iterate manually & pull values from? A more simplified iterator abstraction, essentially:

  ULEBifier U(Value, IsSigned, PadTo);
  while (Optional<char> C = U.next())
    OS.write(*C);

Or something like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78796/new/

https://reviews.llvm.org/D78796





More information about the llvm-commits mailing list