[PATCH] D78968: [llvm][utils] Update llc test updater documentation

[Zola Bridges via Phabricator via llvm-commits]

zbrid created this revision.
zbrid added a reviewer: MaskRay.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This commit explains a common reason this utility fails to work on a given
file it was applied to. I didn't find any other place this utility was
documented, so I added this information in the script's header comment.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78968

Files:
  llvm/utils/update_llc_test_checks.py


Index: llvm/utils/update_llc_test_checks.py
===================================================================
--- llvm/utils/update_llc_test_checks.py
+++ llvm/utils/update_llc_test_checks.py
@@ -5,6 +5,10 @@
 This script is a utility to update LLVM 'llc' based test cases with new
 FileCheck patterns. It can either update all of the tests in the file or
 a single test function.
+
+If your function has link attributes it will not match the regex this script
+uses when deciding which functions to update the test cases for. Often the link
+attributes are unnecessary, therefore you should delete them.
 """
 
 from __future__ import print_function


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78968.260475.patch
Type: text/x-patch
Size: 653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200427/927edff7/attachment.bin>