[PATCH] D78586: [MachineVerifier] Add more checks for registers in live-in lists.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 27 15:07:21 PDT 2020


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2472
+          bool FoundPred = false;
+          for (MCRegAliasIterator AliasingRegs(LiveInReg, TRI, true);
+               AliasingRegs.isValid(); ++AliasingRegs) {
----------------
does this `AliasingRegs` shadow `AliasingRegs` declared on line 2470?


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2478
+            }
+          }
+          if (!FoundPred) {
----------------
looks like `llvm::any_of` can be used here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78586/new/

https://reviews.llvm.org/D78586





More information about the llvm-commits mailing list