[PATCH] D78269: [lld-macho] Support X86_64_RELOC_BRANCH
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 27 14:34:19 PDT 2020
MaskRay added inline comments.
================
Comment at: lld/test/MachO/relocations.s:12
+
+# CHECK-LABEL: Disassembly of section __TEXT,__text:
+## Test X86_64_RELOC_BRANCH
----------------
Consider changing `Disassembly of section __TEXT,__text:` to something like `CHECK-LABEL: <_main>:`
It is obvious that the code is in `__TEXT,__text:` so the information adds very little value. On the contrary, `<_main>:` conveys a bit more useful information.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78269/new/
https://reviews.llvm.org/D78269
More information about the llvm-commits
mailing list