[PATCH] D78888: [llvm-objcopy][MachO] Fix symbol table

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:112
+
+  bool isExternalSymbol() const { return !isSTAB() && n_type & MachO::N_EXT; }
 
----------------
smeenai wrote:
> Why do we need the special case for STAB symbols?
according to https://developer.apple.com/documentation/kernel/nlist_64/1583944-n_type?language=objc
if this symbol is a STAB then the entire n_type value is interpreted differently


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78888/new/

https://reviews.llvm.org/D78888