[PATCH] D78961: [WIP][FileCollector] Add doc comments

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCollector.h:22
 
-/// Collects files into a directory and generates a mapping that can be used by
-/// the VFS.
+/// Collects files into a directory and generates a mapping for RedirectingFileSystem.
+///
----------------
for **the** RedirectingFileSystem


================
Comment at: llvm/include/llvm/Support/FileCollector.h:24
+///
+/// For given existing files we (at some point) create:
+/// - a copy of the file inside StorageDir
----------------
`s/at some point/eventually/`


================
Comment at: llvm/include/llvm/Support/FileCollector.h:84
+  /// The directory where collected files are copied to in copyFiles().
+  const std::string StorageDir;
 
----------------
I'm not a fan of this rename, for two reasons:

 - It is the root of where files are copied.
 - It is the root of the RedirectingFileSystem. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78961/new/

https://reviews.llvm.org/D78961