[PATCH] D78106: [CSInfo][NFC] Interpret loaded parameter value separately

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:642
 
-/// Try to interpret values loaded into registers that forward parameters
-/// for \p CallMI. Store parameters with interpreted value into \p Params.
-static void collectCallSiteParameters(const MachineInstr *CallMI,
-                                      ParamSet &Params) {
-  auto *MF = CallMI->getMF();
-  auto CalleesMap = MF->getCallSitesInfo();
-  auto CallFwdRegsInfo = CalleesMap.find(CallMI);
+/// Interpret the value loaded into register by \p curMI.
+static void interpretValue(const MachineInstr *CurMI,
----------------
Nit: `curMI` -> `CurMI`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:796
 
-    getForwardingRegsDefinedByMI(*I, FwdRegDefs);
-    if (FwdRegDefs.empty())
-      continue;
+    // Skip bundle headers and NOP description.
+    interpretValue(CurMI, ForwardedRegWorklist, Params);
----------------
Sorry, but I don't understand what it means to skip "NOP description" in this context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78106/new/

https://reviews.llvm.org/D78106