[PATCH] D78804: [LICM] Precompute memory writers for AST aliasing analysis

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 26 21:15:13 PDT 2020


mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:780
+  // Collect memory-writing instructions.
+  auto LoopMemWrites = collectMemWrites(CurLoop);
+
----------------
asbirlea wrote:
> Would this also be useful inside `sinkRegion()`, or have it precomputed outside the calls?
Need to check, thanks for catching this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78804/new/

https://reviews.llvm.org/D78804





More information about the llvm-commits mailing list