[PATCH] D78132: [PowerPC] Refactor PPCInstrVSX.td

Sun Apr 26 19:07:08 PDT 2020

nemanjai added a comment.

In D78132#1994682 <https://reviews.llvm.org/D78132#1994682>, @jsji wrote:

> Yes, agree. But before we model what needs to be modeled, maybe don't unset the flag in this refactor patch?

Are you recommending that I ensure that the side effects flag remains set/unset exactly as it currently is with this refactor? I suppose I am fine with that as it separates out the patch to set the flag from the refactoring. I'll explicitly set the flag on instructions that currently have it set (along with a `FIXME`). Then I'll post a follow up patch that removes the explicitly set flag on instructions that I feel should not have the flag set. Is that acceptable?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78132/new/

https://reviews.llvm.org/D78132