[PATCH] D78776: [llvm-objdump] Print target address with evaluateMemoryOperandAddress()

[Seiya Nuta via Phabricator via llvm-commits]

seiya added a comment.

Nitpick in summary: Perhaps you might want to refer to D63847 <https://reviews.llvm.org/D63847> instead of D63746 <https://reviews.llvm.org/D63746>?



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1519
           uint64_t Target;
-          if (MIA->evaluateBranch(Inst, SectionAddr + Index, Size, Target)) {
+          bool PrintedTarget =
+              MIA->evaluateBranch(Inst, SectionAddr + Index, Size, Target);
----------------
How about removing `PrintedTarget`?

```
lang=cpp
          bool PrintTarget =
              MIA->evaluateBranch(Inst, SectionAddr + Index, Size, Target);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78776/new/

https://reviews.llvm.org/D78776